Merge dev-talesam into main - #130
Merged
Merged
Conversation
Remove external path dependencies on big-rust-components so makepkg can build from the mirrored source tree used by CI/CD. - add local subprocess, HTTP, and UI helper modules - restore reqwest for manager HTTP requests - copy package data without preserving ownership in fakeroot - ignore generated makepkg package archives Validated with: - ./scripts/validate-customizations.sh - makepkg -f - cargo build --release --bin big-webapps-gui --locked
…BUILD path Icons: four defects made the launcher show a blurry 32px icon. `reqwest` lacked the `gzip` feature, so every manifest.json served gzipped failed to parse and the 512/1024px sets PWAs declare there were never seen. `magick -` could not decode any .ico (needs `ICO:-`) and without a frame index wrote icon_0-0.png, reporting success for a missing file. Ranking trusted the author-supplied `sizes` hint, so an unlabelled 512px PNG lost to a declared 32x32 — new favicon/image.rs measures real pixels from the container headers. ICO frame choice was left to gdk-pixbuf, which returns the 16px one; now the largest is picked. Also demoted mask-icon, raised the 1MB cap that rejected real 1024px PNGs, fixed extensions for JPEG/WebP/GIF, deduped candidates, kept the port in the /favicon.ico fallback, and upscale the winner to 512px. Measured pixels alone then let Discord and Slack pick their 1200x630 og:image banner, so shape and provenance gate the comparison. Over 14 sites: Spotify 32x32 -> 512x512, banners -> 512x512, rest 512x512 or scalable SVG. Cookies: libsoup's Sqlite jar overflows expiries past 2038 (2040 reads back as 2094) and degrades SameSite=None to Lax — both reproduced on 3.6.6, both visible in real profiles here. Switch to the Text jar, which preserves both. `set_persistent_storage` converts nothing, so window/cookie_migration.rs converts the legacy jar first; otherwise the first launch after a package update silently logs the user out of every internal-browser webapp. The marker is the jar's cookie count, not the file's existence: libsoup writes a header on open, so gating on the file would strand already-launched profiles. Verified on profile copies: 50, 5 and 2 cookies recovered. 1B DRM gate: `match_url` did `url.contains(domain)` over `HashMap::values()` — ──"www.netflix.com" contains "x.com", so the DRM-free X template matched Netflix, and HashMap order made music.youtube.com resolve at random, so the block from 9a906c9 fired only sometimes. Match on the parsed host with a label boundary, most specific wins, tie-break by template_id. `requires_drm` also falls back to the registrable domain, since spotify.com missed open.spotify.com. Nextcloud UA: the decision was not persisted, so every launch fetched the login page under the spoofed UA and switched mid-load, never reloaded, and listened on every cookie change dumping the whole jar. Now persisted per profile and applied before the first request, detected on load-changed with a bounded budget, reloading on adoption. Corrected the rationale too: a live GET /login sets the strict sentinel under either UA, so it identifies Nextcloud rather than signalling a failed check — the old comment implied the trigger was suppressed by the very UA meant to detect it. Packaging: move the PKGBUILD back to pkgbuild/, the path every other BigLinux repo uses and where the build farm looks; it had drifted to packaging/arch/. The PKGBUILD resolves the repo root relative to its own directory, so the offset drops from `../..` to `..` — otherwise it silently falls back to a network git fetch instead of the working tree. Fixed the prepare() excludes, .gitignore, flatpak skip list and docs to match. build-package.yml was fully commented out (no push built anything) and its guard grepped the old path; re-enabled in the canonical form used by appimage-creator. Verified with a full makepkg run from the new path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by GitRepo.