fix(v4): append array items individually in __addInputValues for FormData - #3965
Open
AndrewGit25 wants to merge 3 commits into
Open
fix(v4): append array items individually in __addInputValues for FormData#3965AndrewGit25 wants to merge 3 commits into
AndrewGit25 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves an issue where multi-value elements processed manually by HTMX (e.g., via
hx-include, non-form containers, or custom web components whose.valueproperty returns an Array) serialize as a single comma-separated string (fruit=banana,apple) instead of individual keys (fruit=banana&fruit=apple).Context & Root Cause
<form>elements, nativeFormDataautomatically appends multiple entries for multi-value inputs like<select multiple>.__addInputValues(such as forhx-includeor custom elements outside a form), passing an array toFormData.append(name, input.value)invokesArray.prototype.toString(), coercing the array into a comma-separated string.__addInputValuesto detect arrays (Array.isArray(input.value)) and append each item individually, bringing manual value collection into parity with native<form>multi-value serialization.Changes
__addInputValuesinsrc/htmx.jsto handleArray.isArray(input.value)by iterating over each item and callingformData.append(name, item).if (v != null)) sonullorundefinedvalues inside arrays or standalone properties are safely skipped rather than stringified to"null".test/tests/unit/__collectFormData.jscovering array serialization and null-filtering for both form and non-form elements.Corresponding issue: N/A
Testing
__collectFormData: 37/37 passed.npm test): All 87 test files (1,670 tests) passed with 0 failures.<custom-select>component returning an array.value, successfully producing repeated query parameters matching native<select multiple>behavior.Checklist
devorfour-dev)npm run test) and verified that it succeeded