Relicense to dual MIT OR Apache-2.0 - #88
Open
notmandatory wants to merge 2 commits into
Open
notmandatory wants to merge 2 commits into
notmandatory wants to merge 2 commits into
Conversation
luisschwab
requested changes
Sep 15, 2026
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
Member
There was a problem hiding this comment.
I think we can drop the LICENSE file since GitHub cannot parse it. LICENSE-APACHE, LICENSE-MIT and the README are enough.
luisschwab
requested changes
Sep 15, 2026
luisschwab
left a comment
luisschwab
left a comment
Member
There was a problem hiding this comment.
Missing the Copyright notice on LICENSE-MIT
| @@ -0,0 +1,16 @@ | |||
| Permission is hereby granted, free of charge, to any person obtaining a copy of | |||
Member
There was a problem hiding this comment.
Suggested change
| Permission is hereby granted, free of charge, to any person obtaining a copy of | |
| Copyright (c) 2024-2026 Bitcoin Dev Kit | |
| Permission is hereby granted, free of charge, to any person obtaining a copy of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update LICENSE to MIT or Apache 2.0 and add SPDX-License-Identifier to all source files.
Notes to the reviewers
This closes #78
Changelog notice
Other:
Before submitting