Performance: feat - skip no-op portfolio populate updates and narrow slice selectors - #2316
Closed
JohnathanWhite wants to merge 1 commit into
Closed
JohnathanWhite wants to merge 1 commit into
JohnathanWhite wants to merge 1 commit into
Conversation
UPDATE_POPULATE_PROGRESS is dispatched from a 200ms poll and returned a brand-new slice object on every tick even when every field was identical, re-rendering every component that subscribed to the whole PORTFOLIO slice. The reducer now bails out when nothing changed, and the five whole-slice subscribers select only the fields they read - three of them just a boolean, so they re-render when populate starts and stops rather than on every tick.
msalcala11
approved these changes
Aug 21, 2026
Collaborator
|
Already implemented here: #2241. We can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE_POPULATE_PROGRESS is dispatched from a 200ms poll and returned a brand-new slice object on every tick even when every field was identical, re-rendering every component that subscribed to the whole PORTFOLIO slice. The reducer now bails out when nothing changed, and the five whole-slice subscribers select only the fields they read - three of them just a boolean, so they re-render when populate starts and stops rather than on every tick.