Skip to content

fix: cuthill_mackee_ordering.cppmodernized and actually tests - #557

Open
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/cuthill-mckee-assert
Open

fix: cuthill_mackee_ordering.cppmodernized and actually tests#557
Becheler wants to merge 1 commit into
boostorg:developfrom
Becheler:fix/cuthill-mckee-assert

Conversation

@Becheler

Copy link
Copy Markdown
Collaborator

Code coverage is very unstable, I am fixing unit tests, and many are not asserting much and only printing to cout, which is never checked: failed test still show as PASS.

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

  • rewrote the test to actually verify instead of just printing: each Cuthill-McKee ordering is now checked to be a valid permutation, with bandwidth asserted not to worsen.
  • xan't expect exact orderings (ties, std::sort etc would break on platforms), instead use invariants (mirrors king_ordering test).
  • modernized: typedef/using, constexpr where possible, main() with no unused params.

Motivation

Flickering CI code coverage.

Testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@Becheler Becheler self-assigned this Aug 10, 2026
@Becheler Becheler added technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. test Adding, fixing or modernizing unit tests labels Aug 10, 2026
@github-actions

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 31394312065 vs develop run 31385980713 (7cbc2f59da).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 68 → 68 (0)

@github-actions

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 31394312132 vs develop run 31385980794 (7cbc2f59da).

Job Baseline After Delta
macos (clang, 14) 681 681 0
macos (clang, 17) 641 641 0
macos (clang, 20) 641 641 0
ubuntu (clang-19, 14) 681 681 0
ubuntu (clang-19, 17) 641 641 0
ubuntu (clang-19, 20) 641 641 0
ubuntu (clang-19, 23) 641 641 0
ubuntu (gcc-14, 14) 827 827 0
ubuntu (gcc-14, 17) 949 949 0
ubuntu (gcc-14, 20) 949 949 0
ubuntu (gcc-14, 23) 949 949 0
windows_msvc_14_3 (msvc-14.3) 962 962 0

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.80%. Comparing base (bc05361) to head (7cbc2f5).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #557      +/-   ##
===========================================
+ Coverage    88.22%   92.80%   +4.58%     
===========================================
  Files          392      392              
  Lines        27412    28156     +744     
  Branches      7997     7992       -5     
===========================================
+ Hits         24183    26131    +1948     
- Misses        1881     1919      +38     
+ Partials      1348      106    -1242     
Files with missing lines Coverage Δ
test/cuthill_mckee_ordering.cpp 100.00% <100.00%> (ø)

... and 288 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e818d4...7cbc2f5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Becheler Becheler changed the title fix: modernized and actually tests fix: cuthill_mackee_ordering.cppmodernized and actually tests Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. test Adding, fixing or modernizing unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant