Skip to content

Fix underflow in BesselK - #1448

Open
NAThompson wants to merge 1 commit into
developfrom
bessel_k_scale_1229
Open

Fix underflow in BesselK#1448
NAThompson wants to merge 1 commit into
developfrom
bessel_k_scale_1229

Conversation

@NAThompson

Copy link
Copy Markdown
Collaborator

Closes #1229

@NAThompson
NAThompson requested a review from jzmaddock September 1, 2026 14:50
Comment thread test/test_bessel_k.cpp
@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.41%. Comparing base (3c1c431) to head (068497a).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
.../boost/math/special_functions/detail/bessel_ik.hpp 90.90% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1448   +/-   ##
========================================
  Coverage    95.40%   95.41%           
========================================
  Files          831      831           
  Lines        69540    69572   +32     
========================================
+ Hits         66346    66379   +33     
+ Misses        3194     3193    -1     
Files with missing lines Coverage Δ
.../boost/math/special_functions/detail/bessel_kn.hpp 100.00% <100.00%> (ø)
test/test_bessel_k.cpp 94.73% <100.00%> (+1.40%) ⬆️
.../boost/math/special_functions/detail/bessel_ik.hpp 98.96% <90.90%> (-1.04%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1c431...068497a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jzmaddock

Copy link
Copy Markdown
Collaborator

Thanks for this, does it fix my revised test case in #1229? Looks like it should?

@NAThompson

NAThompson commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator Author

@jzmaddock : Added your test case-cycling through CI now.

Take a look at your convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious underflow in cyl_bessel_k

3 participants