Fix Python dependency compatibility - #439
Open
dellaert wants to merge 1 commit into
Open
Conversation
dellaert
marked this pull request as ready for review
August 26, 2026 22:40
kshaji3
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GTDynamics currently requires
numpy>=2.0.0while acceptinggtsam>=4.2. Those constraints are unnecessarily restrictive and can also be internally inconsistent: GTSAM 4.2 wheels were constrained to NumPy 1.x, while current GTSAM 4.3 supports both NumPy 1.x and 2.x.This change:
numpy>=1.11.0;gtsam>=4.3a0, avoiding the older 4.2 wheel line that was pinned below NumPy 2.This lets pip retain a compatible NumPy 1.x installation instead of reporting a false conflict or forcing an unnecessary NumPy 2 upgrade.
Verification
pip install --dry-run .resolved successfully with NumPy 1.26.4 and GTSAM 4.3a2.KeyError: 'declaration_module_def'); this is unrelated to the dependency metadata change.@kshaji3, could you please check out this branch locally and make sure the wrapper and test suite still work in your setup?