Skip to content

chore: Pass on attachments in e2e test prod forwarding #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luca Forstner (lforst) merged 1 commit into from
Aug 26, 2026
Merged

chore: Pass on attachments in e2e test prod forwarding #2405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions e2e/helpers/mock-braintrust-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,16 @@ export async function startMockBraintrustServer(
capturedRequest.method === "POST" &&
capturedRequest.path === "/attachment"
) {
if (prodForwarding) {
const forwardedResponse = await forwardProdRequest(capturedRequest);
respondJson(
res,
200,
(await forwardedResponse.json()) as JsonValue,
);
return;
}

const key =
isRecord(capturedRequest.jsonBody) &&
typeof capturedRequest.jsonBody.key === "string"
Expand All @@ -706,6 +716,11 @@ export async function startMockBraintrustServer(
capturedRequest.method === "POST" &&
capturedRequest.path === "/attachment/status"
) {
if (prodForwarding) {
await forwardProdRequest(capturedRequest, {
drainResponseBody: true,
});
}
respondJson(res, 200, { ok: true });
return;
}
Expand Down
Loading