feat(harbor): upload standard verifier output - #716
Conversation
02ccbe3 to
9e75b9f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02ccbe3675
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| execution_input["extra_instructions"] = extra_instructions | ||
| selected_artifacts, artifact_attachment_warnings = _artifact_attachments(result, self.config) | ||
| metadata["harbor"]["warnings"].extend(artifact_attachment_warnings) | ||
| attachment_bytes = _attachments_size(selected_artifacts) |
There was a problem hiding this comment.
Include trajectory images in the attachment budget
When trajectory_mode="atif", import_trajectory() can add image Attachments from atif.py to the agent spans, but this counter starts with only selected_artifacts and is not updated after the trajectory import. For example, with both size limits set to 5 MB, a 4 MB trajectory image followed by a 2 MB verifier attachment is accepted even though the trial uploads 6 MB, so the newly shared max_total_attachment_bytes limit is not actually enforced. Include ATIF attachment sizes in the remaining budget before collecting verifier and reward-detail evidence.
Useful? React with 👍 / 👎.
Summary
Complexity
Testing