chore(status): bt status prints which secret storage is used - #341
chore(status): bt status prints which secret storage is used#341Cedric / ViaDézo1er (viadezo1er) wants to merge 1 commit into
Conversation
clarifies that config.json is metadata and not secrets
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef6de491ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| SecretStorageInfo { | ||
| backend: SECURE_STORAGE_BACKEND.expect("secure storage backend checked above"), | ||
| path: None, |
There was a problem hiding this comment.
Verify the secure backend before reporting it
On Linux or macOS, when the secure-store utility or service is unavailable and secrets.json is absent or empty, this branch reports the platform secure backend solely from the compile target. For example, a Linux installation without secret-tool can show Linux Secret Service (via secret-tool) even while profile verification reports a missing credential and any subsequent save would fall back to plaintext. Probe backend availability or report that no active backend was detected instead of claiming the secure backend is in use.
Useful? React with 👍 / 👎.
clarifies that config.json is metadata and not secrets
Read the description of #344, this PR might need tweaking to better support Windows.
Before:
After: