Skip to content

Fix AudioFrameV3Wrapper::get_data() to return correct float32 audio data #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ichux wants to merge 4 commits into
base: master
Choose a base branch
from
+11 −11
Open

Fix AudioFrameV3Wrapper::get_data() to return correct float32 audio data #45

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cffa1cd
Fix AudioFrameV3Wrapper::get_data() to return correct float32 audio data
ichux Sep 1, 2026
d5197c9
Fix AudioFrameV3Wrapper::get_data() float buffer and syntax error
ichux Sep 5, 2026
114262c
Fix AudioFrameV3Wrapper float32 consistency and buffer syntax error
ichux Sep 6, 2026
45f8fcb
aligned a section
ichux Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ struct AudioFrameV2Wrapper {

struct AudioFrameV3Wrapper {
std::string metadata_str;
py::array_t<uint8_t> data_array;
py::array_t<float> data_array;
NDIlib_audio_frame_v3_t inner{};

AudioFrameV3Wrapper(int sample_rate, int no_channels, int no_samples,
Expand Down Expand Up @@ -253,22 +253,22 @@ struct AudioFrameV3Wrapper {
metadata_str = s;
inner.p_metadata = metadata_str.c_str();
}
void set_data(py::array_t<uint8_t> arr) {
void set_data(py::array_t<float> arr) {
data_array = std::move(arr);
auto info = data_array.request();
inner.p_data = static_cast<uint8_t *>(info.ptr);
inner.p_data = static_cast<float *>(info.ptr);
inner.no_channels = info.shape[0];
inner.no_samples = info.shape[1];
inner.channel_stride_in_bytes = info.strides[0];
}
py::array get_data() const {
if (!inner.p_data)
return py::array_t<uint8_t>();
return py::array_t<float>();
size_t col = inner.no_samples, row = inner.no_channels,
size = sizeof(uint8_t);
size = sizeof(float);
return py::array(py::buffer_info(inner.p_data, size,
py::format_descriptor<uint8_t>::format(),
2, {row, col}, {col * size * 4, size}));
py::format_descriptor<float>::format(),
2, {row, col}, {col * size, size}));
}
};

Expand Down Expand Up @@ -830,10 +830,10 @@ PYBIND11_MODULE(NDIlib, m) {
s.inner.FourCC = v;
})
.def_property(
"data", [](const AudioFrameV3Wrapper &s) { return s.get_data(); },
[](AudioFrameV3Wrapper &s, py::array_t<uint8_t> arr) {
s.set_data(std::move(arr));
})
"data", [](const AudioFrameV3Wrapper &s) { return s.get_data(); },
[](AudioFrameV3Wrapper &s, py::array_t<float> arr) {
s.set_data(std::move(arr));
})
.def_property(
"channel_stride_in_bytes",
[](const AudioFrameV3Wrapper &s) {
Expand Down