Add "Sum Total" rows to analyses of existing data, not just fresh benchmarks - #331
Merged
fitzgen merged 2 commits intoAug 13, 2026
Merged
Conversation
…chmarks We were previously only reporting "Sum Total" rows for freshly recorded benchmarks, and not for `sightglass effect-size ...` or `sightglass summarize ...` analyses on already-recorded data. This commit makes it so that we always report the "Sum Total" row in both cases. Also fixes a bug where we weren't totalling across processes, so each process got its own "Sum Total" row instead of accumulating them all together into one row.
Member
Author
|
@posborne mind taking a look at this one? |
posborne
approved these changes
Aug 12, 2026
posborne
approved these changes
Aug 12, 2026
posborne
left a comment
posborne
left a comment
Collaborator
There was a problem hiding this comment.
I probably should have noticed that missing module in my review; looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously only reporting "Sum Total" rows for freshly recorded benchmarks, and not for
sightglass effect-size ...orsightglass summarize ...analyses on already-recorded data. This commit makes it so that we always report the "Sum Total" row in both cases.Also fixes a bug where we weren't totalling across processes, so each process got its own "Sum Total" row instead of accumulating them all together into one row.