feat: introduce injectable filesystem context - #169
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
Introduces a filesystem context for Harness and applies it to the GitHub Action so its filesystem-dependent behavior can be tested without host temporary directories.
How does it work?
@react-native-harness/toolsnow provides an AsyncLocalStorage-backed context, a real Node filesystem default, and a memfs-powered testing helper. The GitHub Action establishes that context at its entrypoints, usesgetFs()in migrated code, and keeps runner logic separately callable under an in-memory filesystem.Why is this useful?
Action tests become hermetic and faster to reason about, while the new port creates a consistent path for incrementally migrating the remaining Harness filesystem usage.
Closes #165