Skip to content

ci: disable CodeQL - #765

Merged
Ferryx349 merged 3 commits into
mainfrom
ci/disable-codeql
Sep 8, 2026
Merged

ci: disable CodeQL#765
Ferryx349 merged 3 commits into
mainfrom
ci/disable-codeql

Conversation

@Ferryx349

@Ferryx349 Ferryx349 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR removes the CodeQL Advanced GitHub Actions workflow

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

Remove the CodeQL workflow, config, custom models, changeset, and route
suppression comments to stop false-positive security findings on admin routes.
@changeset-bot

changeset-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f95f67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls

coveralls commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 72.235%. remained the same — ci/disable-codeql into main

@phoenix-server

Copy link
Copy Markdown
Collaborator

Verdict: approve. Clean removal — workflow, custom query pack, config, and the now-dead // codeql[...] suppression comments all go together, and the src/routes/* changes are comment-only (no rate limiting or auth behavior touched). Deleting the pending codeql-admin-rate-limit-models.md changeset is correct pairing since the models pack it describes is being deleted too.

One nit, non-blocking: ci: disable CodeQL is a CI-only change, which by CONTRIBUTING convention would normally ship an empty changeset — as written it adds a patch bump (though it nets out to zero since the deleted changeset was also patch, so the next release content is unchanged either way).

Merging per maintainer direction.

@phoenix-server phoenix-server left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve - clean removal, comment-only src changes.

@Ferryx349
Ferryx349 merged commit 3690bd8 into main Sep 8, 2026
18 checks passed
@Ferryx349
Ferryx349 deleted the ci/disable-codeql branch September 8, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants