Conversation
Adds `TestReverseDNSCancellationActive` to `pkg/discovery/net_test.go` to verify that no goroutines leak when `ReverseDNS` is cancelled prematurely. Checked using a threshold on `runtime.NumGoroutine()`. Co-authored-by: mendsec <12684528+mendsec@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Up to standards ✅🟢 Issues
|
Added
TestReverseDNSCancellationActivetopkg/discovery/net_test.goto verify thatReverseDNSdoes not leak goroutines during early cancellation. Checked by taking a baseline of goroutines before runningReverseDNSand ensuring that it returns to within a threshold of <= 3 after the background context cancels.PR created automatically by Jules for task 9384047681915600896 started by @mendsec