fix: drop android.newdsl=false for agp 9 - #442
Merged
cdsap merged 2 commits intoSep 5, 2026
Merged
Conversation
Owner
Author
|
@cdsap PR Judge blocked this PR for manual review. State: The judge will not auto-merge this PR until the risky diff is reviewed manually. |
Metro Gradle plugin 1.4.2 requires JVM 21, but Gradle TestKit runs on the test JVM. Skip the Metro variant when CI executes on JDK 17. Co-authored-by: Cursor <cursoragent@cursor.com>
cdsap
deleted the
issue/441-hermes-drop-android-newdsl-false-for-agp-9-a1
branch
September 5, 2026 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evaluate if we can drop
android.newDsl=falsefor projects generated with AGP9+.We need to generate projects without the property and test that the project compiles, and hits the configuration cache for the different variants of DI
Fixes #441
Changes
.github/workflows/build.yml.github/workflows/update-gradle-versions.ymlproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/generator/rootproject/GradleProperties.ktproject-generator/src/test/kotlin/io/github/cdsap/projectgenerator/Agp9NewDslDiVariantsE2EValidationTest.ktproject-generator/src/test/kotlin/io/github/cdsap/projectgenerator/generator/files/GradlePropertiesTest.ktVerification
./gradlew :project-generator:unitTest./gradlew :cli:test./gradlew ktlintCheck