Pass message_factory to reflection->GetMessage in cel::Value::WrapField. - #2186
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_957173111
branch
3 times, most recently
from
August 3, 2026 11:45
c3e873f to
1c052b2
Compare
Inside WrapFieldImpl in value.cc, CEL called reflection->GetMessage(*message, field) without passing message_factory as the 3rd argument. When message is a compiled C++ GeneratedMessage, Protobuf reflection defaulted factory to MessageFactory::generated_factory(). If field is an extension whose descriptor lives in a dynamic DescriptorPool, generated_factory()->GetPrototype(extension_desc) returns nullptr, causing a SIGSEGV (@(nil)) in ExtensionSet::GetMessage(). This CL passes message_factory to reflection->GetMessage(*message, field, message_factory) so Protobuf reflection uses CEL's MessageFactory to resolve dynamic extensions. PiperOrigin-RevId: 958311978
copybara-service
Bot
force-pushed
the
test_957173111
branch
from
August 3, 2026 12:08
1c052b2 to
4f1003d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass message_factory to reflection->GetMessage in cel::Value::WrapField.
Inside WrapFieldImpl in value.cc, CEL called reflection->GetMessage(*message, field)
without passing message_factory as the 3rd argument. When message is a compiled C++
GeneratedMessage, Protobuf reflection defaulted factory to MessageFactory::generated_factory().
If field is an extension whose descriptor lives in a dynamic DescriptorPool,
generated_factory()->GetPrototype(extension_desc) returns nullptr, causing a
SIGSEGV (@(nil)) in ExtensionSet::GetMessage().
This CL passes message_factory to reflection->GetMessage(*message, field, message_factory)
so Protobuf reflection uses CEL's MessageFactory to resolve dynamic extensions.