CFE-90: document remount, remount_methods and remount_timeout mount attributes - #3731
Open
nickanderson wants to merge 2 commits into
Open
CFE-90: document remount, remount_methods and remount_timeout mount attributes#3731nickanderson wants to merge 2 commits into
nickanderson wants to merge 2 commits into
Conversation
|
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
nickanderson
force-pushed
the
CFE-90/master_mount_options
branch
from
July 13, 2026 02:20
9142cb7 to
f78d23c
Compare
nickanderson
marked this pull request as ready for review
August 4, 2026 00:23
Member
Author
|
@cf-bottom jenkins please |
…ttributes Document the new opt-in reconciliation of a live mount's options, and clarify that mount_options are only enforced against a running mount when remount is enabled (they otherwise affect just the initial mount and, with edit_fstab, the fstab entry). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nickanderson
force-pushed
the
CFE-90/master_mount_options
branch
from
August 5, 2026 20:21
f78d23c to
54b3224
Compare
…remount Documents the rest of the user-visible changes made alongside the opt-in remount reconciliation: - mount body: a promise for an unmounted filesystem now mounts only that filesystem instead of arming 'mount -a' (CFE-1863) - edit_fstab: the file system table entry is maintained for an already-mounted filesystem, how an existing entry is matched and compared, and the platform default options used when mount_options is unset (CFE-1539) - mount_server: the server is part of mount identity when remount or unmount is enabled, and changing it needs unmount_mount (CFE-2350) - unmount: mount_source and mount_server select which mount to act on, and a different filesystem at the promiser is left alone (CFE-2350) - remount: also governs correcting a mount point holding a different filesystem - remount_timeout: allowed input range Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nickanderson
force-pushed
the
CFE-90/master_mount_options
branch
from
August 5, 2026 20:27
54b3224 to
bc6783c
Compare
craigcomstock
approved these changes
Aug 7, 2026
| earlier conflicting one — for example `{ "defaults", "ro" }` is a read-only | ||
| mount and `{ "ro", "rw" }` is read-write. The `defaults` pseudo-option is | ||
| expanded to its checkable parts (`rw`, `suid`, `dev`, `exec`, `async`) and is | ||
| satisfied unless a conflicting negative such as `ro`, `nosuid` or `sync` is |
Contributor
There was a problem hiding this comment.
This is not very clear what a "conflicting negative" is. Maybe "... and is satisfied unless an additional option given conflicts with the options included in the "defaults" keyword in which case the non-conflicting options plus the conflicting option are all included.
Are we somehow determining the set of options that defaults would bring?
man fstab(5) seems to indicate that the set of defaults varies on the filesystem
defaults
use default options. The default depends on the kernel and the
filesystem. mount(8) does not have any hardcoded set of
default options. The kernel default is usually rw, suid, dev,
exec, auto, nouser, and async.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the storage mount attributes and behavior changes that landed with core PR #6222 for 3.29.0: the new
remount,remount_methodsandremount_timeoutattributes, and themount,edit_fstab,mount_serverandunmountchanges that shipped alongside them.Ticket: https://northerntech.atlassian.net/browse/CFE-90