Fix Token::from_encoded accepting a double tilde - #129
Merged
Conversation
The escaped-tilde branch set `escaped = true` unconditionally, so a `~` following an already-open escape (e.g. the second `~` in "~~0") was treated as re-opening the escape instead of being rejected. This let safe code build a PointerBuf via Token::from_encoded that Pointer::parse then refused on the same bytes. Fixes #128
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Token::from_encodedsetescaped = trueunconditionally when it saw~, so a second~right after an already-open escape (e.g. the second~in"~~0") was treated as re-opening the escape rather than being rejected as an invalid escape sequence.Token::from_encoded→PointerBuf::from_tokens) construct aPointerBufwhose string formPointer::parsethen refused on the exact same bytes.~seen while already escaped now falls through to the existing "invalid character after tilde" error path.Fixes #128
Test plan
src/token.rsassertingToken::from_encoded("~~0")returnsEncodingError { offset: 1, source: InvalidEncoding::Tilde }cargo test --all-features(105 lib tests + 49 doc tests) passescargo clippy --all-features --all-targetsis clean