[Server] Keep injectable parameters out of the published inputSchema - #47
Closed
chr-hertel wants to merge 1 commit into
Closed
chr-hertel wants to merge 1 commit into
chr-hertel wants to merge 1 commit into
Conversation
This was referenced Aug 22, 2026
Owner
Author
|
Merged upstream with modelcontextprotocol#482 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tool handler typed against
ClientGatewaypublished a phantom parameter in itsinputSchema, and argument validation then rejected every legitimate call:ReferenceHandler::prepareArguments()injectedRequestContextandClientGateway, butSchemaGenerator::parseParametersInfo()only skippedRequestContext.The injectable set now lives in one place,
InjectableParameters, read by both sides — schema generation viasupports(), argument preparation viaresolve()— so they cannot drift again. Behavior is otherwise unchanged.Regression tests: schema generation excludes
ClientGateway/RequestContextparameters,ReferenceHandlerstill injects the gateway, and an integration test proves a gateway-typed tool publishes a clean schema and stays callable end to end.Closes #25. Also fixes the injectable-drift half of #13 (the metadata-factory half stays open).
Confidence: 9/10 — minimal verbatim-moved logic, new tests fail without the fix, full unit+integration suites, cs-fixer and phpstan green.