Skip to content

Fix modified_at comparisons to use Timex.compare and seconds granularity #1202

Description

@joshsmith

Problem

Currently we have some GitHub events erroring due to too much granularity. Our timestamps are stored with millisecond-level accuracy whereas we need to compare on :seconds with GitHub since they only store (or at least display) at the level of seconds.

This means using Timex.compare and passing in :seconds for the granularity.

This needs a failing test to verify that this is, indeed, the case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions