Skip to content

build(protobuf): Upgrade protobuf minimum version from v4 to v5 (prep for state ts support, DM-4073) - #2776

Merged
haakonvt merged 4 commits into
masterfrom
upgrade-protobuf-for-state-ts
Aug 21, 2026
Merged

haakonvt merged 4 commits into
masterfrom
upgrade-protobuf-for-state-ts

Conversation

@haakonvt

@haakonvt haakonvt commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Bumps the lower bound on protobuf from v4 to v5 as v4 is lacking a version guard at runtime (also, it is ancient!). For reference, the latest is v7.

Note: Not to be merged before cognitedata/protobuf-files#22

Update: TimeLords moved state TS specific part into own PR: cognitedata/protobuf-files#23

@haakonvt
haakonvt requested review from a team as code owners August 19, 2026 08:11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the project's protobuf dependency to version 5, regenerates the proto files with support for state datapoints and aggregates, and updates the proto compilation script. The review feedback suggests making the paths in the update script location-independent by resolving them relative to the script's file location rather than the current working directory.

Comment thread scripts/update_proto_files.py
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.07%. Comparing base (38cbb51) to head (d3e55a4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2776      +/-   ##
==========================================
+ Coverage   93.06%   93.07%   +0.01%     
==========================================
  Files         514      514              
  Lines       52959    52959              
==========================================
+ Hits        49286    49294       +8     
+ Misses       3673     3665       -8     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@haakonvt
haakonvt force-pushed the upgrade-protobuf-for-state-ts branch from 4f7ee1c to 0c28910 Compare August 21, 2026 10:19
@haakonvt haakonvt changed the title chore(deps): Upgrade protobuf in preparation for state time series support deps(protobuf): Upgrade protobuf minimum version from v4 to v5 (prep for state ts support) Aug 21, 2026
@haakonvt haakonvt changed the title deps(protobuf): Upgrade protobuf minimum version from v4 to v5 (prep for state ts support) build(protobuf): Upgrade protobuf minimum version from v4 to v5 (prep for state ts support) Aug 21, 2026
@haakonvt

Copy link
Copy Markdown
Contributor Author

🦄

@haakonvt haakonvt self-assigned this Aug 21, 2026
@haakonvt haakonvt added risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action labels Aug 21, 2026
@haakonvt
haakonvt added this pull request to the merge queue Aug 21, 2026
Merged via the queue into master with commit 3892939 Aug 21, 2026
36 of 38 checks passed
@haakonvt
haakonvt deleted the upgrade-protobuf-for-state-ts branch August 21, 2026 11:24
@haakonvt haakonvt changed the title build(protobuf): Upgrade protobuf minimum version from v4 to v5 (prep for state ts support) build(protobuf): Upgrade protobuf minimum version from v4 to v5 (prep for state ts support, DM-4073) Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk-review-ongoing Risk review is in progress waiting-for-team Waiting for the submitter or reviewer of the PR to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants