fix: add --allow-past-effective-time to simple benchmark - #3490
Open
dheerajodha wants to merge 1 commit into
Open
fix: add --allow-past-effective-time to simple benchmark#3490dheerajodha wants to merge 1 commit into
dheerajodha wants to merge 1 commit into
Conversation
The simple benchmark uses --effective-time with a past date (2024-12-10) but does not pass --allow-past-effective-time, which is now required since past effective times are rejected by default. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe benchmark validation command now includes the ChangesBenchmark validation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🤖 Finished Review · ✅ Success · Started 1:09 PM UTC · Completed 1:15 PM UTC Commit: |
|
Looks good to me Labels: PR fixes a broken benchmark (runtime failure due to missing CLI flag) |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simple benchmark uses --effective-time with a past date (2024-12-10) but does not pass --allow-past-effective-time, which is now required since past effective times are rejected by default.
What:
Add
--allow-past-effective-timeflag to the simple benchmark's argument list.Why:
The simple benchmark uses
--effective-time2024-12-10T00:00:00Z (a past date) but past effective times are now rejected by default (PR #3424). Without this flag the benchmark fails at runtime with: "effective time … is in the past; use --allow-past-effective-time to override".The stress benchmark already has this flag (added in EC-1818). This brings the simple benchmark in line.
Tickets:
N/A — pre-existing issue surfaced during EC-1819 review.