fix(gui): prevent opening a chat when clicking its rename input - #13226
Open
jabrailkhalil wants to merge 1 commit into
Open
fix(gui): prevent opening a chat when clicking its rename input#13226jabrailkhalil wants to merge 1 commit into
jabrailkhalil wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clicking inside the title input while renaming a chat in History also triggers the row's click handler, opening the chat. Stop click propagation on the input so the title remains editable.
One line added in one file.
Validation
Verified before and after in an isolated browser preview of HistoryTableRow with IDE calls stubbed: clicking the input no longer opens the chat; Enter still dispatches the title update, Escape cancels editing, and clicking the row still opens the chat. The full extension test suite was not run.
git diff --checkpasses.