fix(CChipInput): leave the disabled and readonly semantics to the input - #564
Merged
Merged
Conversation
The component stamped aria-disabled and aria-readonly on its container, a plain div with no role. Those states only mean something on a widget role, so assistive technology ignored them there; the real disabled and readonly on the inner input already carry the state and are what gets announced. The attributes are gone and the input keeps both states. The specs that asserted them now assert they are absent.
…donly states The accessibility page said the states are reflected without saying where. It now names the native disabled and readonly on the inner input, which is what assistive technology reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CChipInput stamped aria-disabled and aria-readonly on its container, a plain div with no role. Those states only mean something on a widget role, so assistive technology ignored them there, while the real disabled and readonly on the inner input already carry the state and are what gets announced.
The attributes are gone and the input keeps both states. The specs now assert the container is free of them and that the input carries the state instead.
The same change goes to the vanilla library in coreui/coreui#1197 and to the other framework editions.