-
-
Notifications
You must be signed in to change notification settings - Fork 57
feat: add order-by logic to database queries #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xelab04
wants to merge
22
commits into
cot-rs:master
Choose a base branch
from
xelab04:db-sort-by
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
86bc443
add basic code for ordering
xelab04 8692126
Merge branch 'cot-rs:master' into db-sort-by
xelab04 8fb90e8
change ordering to use fieldref instead of string
xelab04 fe383db
Merge branch 'cot-rs:master' into db-sort-by
xelab04 30bff01
Merge branch 'master' into db-sort-by
m4tx a72f2ec
Merge branch 'master' into db-sort-by
ElijahAhianyo 9a4b9e6
Merge branch 'master' into db-sort-by
ElijahAhianyo 62dbf4e
get this in a much better shape. Still lacking other expressiveness
ElijahAhianyo c34fef0
order_by field. Need a better name
ElijahAhianyo c671e62
much much better API. no tests yet. Also add proper support for custo…
ElijahAhianyo e7df2a9
Merge branch 'master' into db-sort-by
ElijahAhianyo 3100b54
tests, tests and tests
ElijahAhianyo 9734e1c
Merge branch 'master' into db-sort-by
ElijahAhianyo d25dbe0
docs initial draft. needs more work
ElijahAhianyo c3f65f3
Merge remote-tracking branch 'xelab04-fork/db-sort-by' into db-sort-by
ElijahAhianyo 15462cc
Merge branch 'master' into db-sort-by
ElijahAhianyo e88dc1c
improve tests and docs, and more improvements
ElijahAhianyo 718e15e
Merge remote-tracking branch 'xelab04-fork/db-sort-by' into db-sort-by
ElijahAhianyo f32ac80
chore(pre-commit.ci): auto fixes from pre-commit hooks
pre-commit-ci[bot] e6d81fe
bikeshedding
ElijahAhianyo 7ef4696
Merge remote-tracking branch 'xelab04-fork/db-sort-by' into db-sort-by
ElijahAhianyo ef9aad0
increase coverage. Also, remove EprAdd impl for email and url. They a…
ElijahAhianyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something to handle in this PR or a follow-up?