Upstream 2041 - Close idle Valkey connections - #25
Merged
Merged
Conversation
The generated valkey.conf set no timeout, so Valkey never reclaimed idle client connections and long-running instances accumulated them until reaching maxclients. Ports ansible/awx-operator#2041.
blaipr
changed the title
cigamit
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: ansible/awx-operator#2041
SUMMARY
The
valkey_confblock generated byroles/installer/templates/configmaps/config.yaml.j2sets notimeout, so Valkey keeps idle client connections open indefinitely. On long-running instances they accumulate until the server starts refusing new ones withERR max number of clients reached.Upstream applies it to the equivalent
redis_confblock;timeoutis a Redis directive Valkey retains, so it carries over unchanged.For reference, the block as it stands is upstream's minus that one line:
Not present in this fork.
ISSUE TYPE
COMPONENT NAME