Feat/1191 locale based value seperators - #1383
Draft
sneurlax wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #1383 +/- ##
===========================================
- Coverage 4.84% 4.83% -0.01%
===========================================
Files 1092 1092
Lines 109141 109201 +60
===========================================
Hits 5283 5283
- Misses 103858 103918 +60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 18:55
Both files predate the current dart formatter, which fails CI's check of the files a change touches.
Amount input grouped every three digits and, on a paste, simply dropped the locale's group separator, so an amount copied from a differently formatted locale silently changed value: pasting de_DE's 1.234,56 into an en_US field left 1.23456. Group with the locale's own pattern, including the 3/2 Indian one, keep its decimal separator, canonicalize the space separators, and resolve a bulk edit's foreign separators deterministically - local grouping wins where the digits form valid groups, otherwise a lone foreign separator reads as the decimal point. Anything else is rejected outright. Util.getSymbolsFor's last fallback took the region out of a locale string, so every *_IN locale resolved to Indonesian symbols and an unknown two letter locale threw RangeError.
The three transaction fee selection sheets parsed their amount with Decimal.tryParse, which cannot read the grouped text the amount field holds, so the sheet fell back to zero for any amount long enough to be grouped and sized its fee estimates against nothing.
Neither field had an amount input formatter and both parsed raw Decimal text, so a grouped or comma decimal amount was rejected or misread, and a buy quote threw on Decimal.parse instead of reporting an invalid amount. The buy amount is denominated in the crypto being bought, which need not be the wallet's coin and is absent entirely on desktop, so resolve the currency from that selection; with none, fail closed rather than reading a crypto amount with the two decimal fiat parser.
sneurlax
force-pushed
the
feat/1191-locale-based-value-seperators
branch
from
August 25, 2026 17:51
25cc980 to
ba77c49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1191