Fix two recurring CI failures in daily scheduled runs - #1914
Merged
Conversation
1. Exclude `lowest-deps` from the smoke-test-docs step.
That step runs `python "$f"` using the system Python, but in
`lowest-deps` mode `dandi` is only installed inside the tox venv.
Every scheduled run was failing with:
ModuleNotFoundError: No module named 'dandi'
Adding `matrix.mode != 'lowest-deps'` to the condition skips the
step for that matrix entry (the tox run itself already validates the
package under lowest-compatible dependency versions).
2. Add a 30 s timeout to the `requests.get()` calls in
`parse_purlobourl`. Without a timeout the function hangs
indefinitely when ontobee/obolibrary is unreachable, and each test
that calls it only terminates after the 300 s pytest-timeout fires.
With timeout=30 the request raises `requests.exceptions.Timeout`
(a `RequestException` subclass) quickly, so `mark_xfail_ontobee`
can catch it in non-scheduled mode and the tenacity retries also
abort fast instead of each waiting 300 s.
Co-Authored-By: Claude Code 2.1.251 / Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1914 +/- ##
=======================================
Coverage 77.30% 77.30%
=======================================
Files 89 89
Lines 13288 13288
=======================================
Hits 10272 10272
Misses 3016 3016
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yarikoptic-gitmate
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude
lowest-depsfrom the smoke-test-docs step. That step runspython "$f"using the system Python, but inlowest-depsmodedandiis only installed inside the tox venv. Every scheduled run was failing with: ModuleNotFoundError: No module named 'dandi' Addingmatrix.mode != 'lowest-deps'to the condition skips the step for that matrix entry (the tox run itself already validates the package under lowest-compatible dependency versions).Add a 30 s timeout to the
requests.get()calls inparse_purlobourl. Without a timeout the function hangs indefinitely when ontobee/obolibrary is unreachable, and each test that calls it only terminates after the 300 s pytest-timeout fires. With timeout=30 the request raisesrequests.exceptions.Timeout(aRequestExceptionsubclass) quickly, somark_xfail_ontobeecan catch it in non-scheduled mode and the tenacity retries also abort fast instead of each waiting 300 s.