Skip to content

Add Condition class - #9162

Open
nadzhou wants to merge 2 commits into
dask:mainfrom
nadzhou:add-condition-primitive
Open

Add Condition class#9162
nadzhou wants to merge 2 commits into
dask:mainfrom
nadzhou:add-condition-primitive

Conversation

@nadzhou

@nadzhou nadzhou commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

Closes #2007 since other classes have been implemented. Happy to get feedback on this.

@nadzhou
nadzhou requested a review from fjetter as a code owner December 6, 2025 02:07
@github-actions

github-actions Bot commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    40 files  ±  0      40 suites  ±0   14h 58m 25s ⏱️ + 13m 53s
 4 171 tests + 12   3 990 ✅ + 11    178 💤 ±0  3 ❌ +1 
81 179 runs  +239  76 940 ✅ +239  4 236 💤  - 1  3 ❌ +1 

For more details on these failures, see this check.

Results for commit c14a064. ± Comparison against base commit 40fcd99.

♻️ This comment has been updated with latest results.

@nadzhou
nadzhou marked this pull request as draft December 6, 2025 06:19

@jacobtomlinson jacobtomlinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance this seems fine. The CI is hanging on these new tests though so you'll need to take a look at that.

Once you get things running feel free to ping for a review.

@nadzhou

nadzhou commented Dec 14, 2025

Copy link
Copy Markdown
Contributor Author

At a quick glance this seems fine. The CI is hanging on these new tests though so you'll need to take a look at that.

Once you get things running feel free to ping for a review.

Thanks for the reply. Sure let me take a look at this.

@nadzhou
nadzhou force-pushed the add-condition-primitive branch from 34f5cb4 to b16e6fb Compare December 14, 2025 20:47
@nadzhou
nadzhou force-pushed the add-condition-primitive branch from 470135a to 2a34eb0 Compare December 21, 2025 22:31
@nadzhou
nadzhou marked this pull request as ready for review February 8, 2026 22:15
@nadzhou nadzhou closed this Aug 15, 2026
@nadzhou
nadzhou force-pushed the add-condition-primitive branch from 938568c to 40fcd99 Compare August 15, 2026 23:45
@nadzhou nadzhou reopened this Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Semaphore, Condition, Event

2 participants