code fix & added goldens in USCensusPEP_AgeSexRaceHispanicOrigin - #2134
Open
niveditasing wants to merge 14 commits into
Open
code fix & added goldens in USCensusPEP_AgeSexRaceHispanicOrigin#2134niveditasing wants to merge 14 commits into
niveditasing wants to merge 14 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces validation configurations and golden data files for the US Census PEP ASRH import, including adding a validation_config.json and updating the manifest. Additionally, the download script pep_asrh_download_script.py was updated to include a polite delay and a custom User-Agent header when making requests. The review feedback correctly identifies that the time module is imported locally inside functions and loops, which violates PEP 8 guidelines, and recommends moving the import to the top of the file.
saanikaaa
reviewed
Aug 26, 2026
niveditasing
force-pushed
the
fixed_hispanic
branch
from
August 27, 2026 06:53
510b20a to
081c1d2
Compare
saanikaaa
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python Code Fixes (pep_asrh_download_script.py)
Testing Results: https://storage.mtls.cloud.google.com/datcom-import-test/statvar_imports/us_census/pep/us_census_pep_asrh/USCensusPEP_AgeSexRaceHispanicOrigin/2026_08_05T01_31_50_889195_07_00/input0/validation/validation_output.csv