Report json error modified for OECD_Waste_Water_Treatment - #2197
Open
saanikaaa wants to merge 2 commits into
Open
Report json error modified for OECD_Waste_Water_Treatment#2197saanikaaa wants to merge 2 commits into
saanikaaa wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces double-double quotes with single quotes in the oecd_wastewatertreatment_pvmap.csv file. However, using single quotes will result in invalid MCF syntax in the generated MCF file, as MCF string values must be enclosed in double quotes. To resolve this, you should use standard CSV escaping with triple double-quotes instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cloud job for this import was failing due to error in report.json of invalid character present in statvar.mcf file generated by statvar_processor.py script.
To resolve the issue we have replaced double double quoted("") in name property to triple double quoted(""") in the pvmap.
Tested genmcf on the output generated post the fix and it shows zero errors and warning are expected.