Qualify 8.1.3 with hardened release evals - #58
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccc10c1ef6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const exited = new Promise<void>((resolve) => | ||
| child.once("exit", () => resolve()), | ||
| ); | ||
| signalProcessTree(child, "SIGTERM"); |
There was a problem hiding this comment.
On Linux containers where the detached wrapper owns a child process, sending SIGTERM to the entire process group kills the wrapper before it can wait for and reap that child. The child can consequently remain as a zombie, and the later polling and SIGKILL cannot remove it because this process is not its parent; the function then returns after its deadlines with the PID still present. This is reproducible with the newly added bun test tests/eval-reporting.test.ts, whose detached-wrapper test fails at the child-PID assertion, and repeated eval runs can accumulate these entries. Terminate descendants before the wrapper or otherwise arrange for them to be reaped before returning.
Useful? React with 👍 / 👎.
2 participants
Summary
8.1.3and hardens release qualification around canonical release sampling, retained failure evidence, exact regrading, and bounded environment reserves.Verification
bun test tests/grader-input.test.ts tests/eval-reporting.test.ts tests/environment-reserves.test.tsbun run typecheckbun run check.agents/skills/flow-contribution-check/scripts/preflight.sh pushReview Notes
OpenCode reviewer attempts with
opencode/grok-4.6andopencode/gpt-5.6-solwere attempted from a detached temporary worktree atccc10c1with a temporaryXDG_CONFIG_HOME. Both failed before review with an upstream OpenCode gateway 500 on even a one-line prompt. No source files were edited by those reviewer attempts.