Skip to content

fix(examples): register orphan examples in catalog - #3453

Merged
magurotuna merged 3 commits into
mainfrom
fix/example/catalog
Aug 18, 2026
Merged

fix(examples): register orphan examples in catalog#3453
magurotuna merged 3 commits into
mainfrom
fix/example/catalog

Conversation

@magurotuna

Copy link
Copy Markdown
Member

Register Shamir's Secret Sharing and Checking for directory existence in the examples catalog so their pages appear in the sidebar/landing page. Also aligns sss.ts @title with its catalog label.

@magurotuna
magurotuna requested a review from avocet-bot August 17, 2026 10:06
@avocet-bot

avocet-bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Avocet review status

State: Completed
Target: 54d3d9ef3a0b
Requested by: magurotuna
Model: Claude Opus
Attempt: 1 of 3
Updated: 2026-08-17T10:34:18.620Z
Formal review: #3453 (review)

The formal GitHub review is the authoritative result. This comment only reports operational status.

@avocet-bot avocet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review model: Claude Opus

Model verdict: APPROVE (informational only)

Formal review policy did not authorize an authoritative event (required_checks_missing).

No blocking findings.

Verified the two new catalog entries in examples/_data.ts are correct: both referenced scripts exist (examples/scripts/sss.ts, examples/scripts/checking_directory_existence.ts), and their hrefs (/examples/sss/, /examples/checking_directory_existence/) match the page URLs generated by examples/index.examples.page.tsx (/examples/${label}/). Both category values are valid members of categoryOrder, so they render in the sidebar (_data.ts:2040). Entry order doesn't matter since items are alphabetized at build time. The @title edit in sss.ts is a JSDoc tag that now matches the catalog label and has no typecheck/runtime impact. Pure data/doc change with no error handling, logic, or test coverage implications.

@magurotuna
magurotuna requested a review from avocet-bot August 18, 2026 03:03
@avocet-bot

avocet-bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Avocet review status

State: Completed
Target: dd6295fb8c70
Requested by: magurotuna
Model: Claude Opus
Attempt: 1 of 3
Updated: 2026-08-18T03:17:03.773Z
Formal review: #3453 (review)

The formal GitHub review is the authoritative result. This comment only reports operational status.

@avocet-bot avocet-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review model: Claude Opus

Model verdict: APPROVE

No blocking findings. The effective base/head change at current head dd6295f is identical to the previously reviewed change (the new head only merges main into the branch). Re-verified: both catalog entries reference scripts that exist (examples/scripts/sss.ts, examples/scripts/checking_directory_existence.ts); their hrefs (/examples/sss/, /examples/checking_directory_existence/) match the URLs generated by examples/index.examples.page.tsx; both category values are valid members of categoryOrder so they render in the sidebar; and the @title edit in sss.ts is a JSDoc tag now aligned with the catalog label, with no typecheck/runtime impact. No prior findings remain open.

@magurotuna
magurotuna force-pushed the fix/example/catalog branch 3 times, most recently from 454b57d to 0a64406 Compare August 18, 2026 03:56
@magurotuna
magurotuna force-pushed the fix/example/catalog branch from 0a64406 to bd52f16 Compare August 18, 2026 04:04
@magurotuna
magurotuna merged commit eb8f78e into main Aug 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants