Skip to content

Defer SqliteCacheRequestsDocumentLoader cache file creation until first load - #303

Merged
mielvds merged 3 commits into
masterfrom
sqlite-cache-lazy-init
Aug 26, 2026
Merged

Defer SqliteCacheRequestsDocumentLoader cache file creation until first load#303
mielvds merged 3 commits into
masterfrom
sqlite-cache-lazy-init

Conversation

@anatoly-scherbakov

@anatoly-scherbakov anatoly-scherbakov commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Create the SQLite HTTP cache file when the first document is loaded, not when SqliteCacheRequestsDocumentLoader is constructed.
  • Keeps local-only CLI / library use from touching the cache path until an HTTP load happens.

Stack

Base: choice-by-type-document-loader (#304).
Next: command-line-interface (#305).

Test plan

  • pytest tests/test_sqlite_cache_requests_document_loader.py
  • CI green

@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown

@mielvds mielvds left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Pretty elegant improvement

@mielvds
mielvds force-pushed the sqlite-cache-lazy-init branch from 245a5f8 to 9f134b7 Compare August 26, 2026 07:14
Base automatically changed from choice-by-type-document-loader to master August 26, 2026 08:00
@mielvds
mielvds force-pushed the sqlite-cache-lazy-init branch from 9f134b7 to b16e2c2 Compare August 26, 2026 08:00
@mielvds
mielvds merged commit 0a26694 into master Aug 26, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants