Defer SqliteCacheRequestsDocumentLoader cache file creation until first load - #303
Merged
Conversation
3 tasks
anatoly-scherbakov
force-pushed
the
sqlite-cache-lazy-init
branch
from
July 26, 2026 17:39
7a0e4f7 to
999856b
Compare
anatoly-scherbakov
changed the base branch from
master
to
choice-by-type-document-loader
July 26, 2026 17:39
2 tasks
anatoly-scherbakov
force-pushed
the
sqlite-cache-lazy-init
branch
from
August 10, 2026 18:34
999856b to
ded822c
Compare
anatoly-scherbakov
force-pushed
the
sqlite-cache-lazy-init
branch
from
August 21, 2026 18:11
ded822c to
245a5f8
Compare
mielvds
approved these changes
Aug 25, 2026
mielvds
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Pretty elegant improvement
mielvds
force-pushed
the
sqlite-cache-lazy-init
branch
from
August 26, 2026 07:14
245a5f8 to
9f134b7
Compare
mielvds
force-pushed
the
sqlite-cache-lazy-init
branch
from
August 26, 2026 08:00
9f134b7 to
b16e2c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqliteCacheRequestsDocumentLoaderis constructed.Stack
Base:
choice-by-type-document-loader(#304).Next:
command-line-interface(#305).Test plan
pytest tests/test_sqlite_cache_requests_document_loader.py