Render inline image previews - #211
Closed
bobrowadam wants to merge 1 commit into
Closed
Conversation
bobrowadam
force-pushed
the
bob/image-previews-pr
branch
from
May 30, 2026 20:03
c398ac0 to
5023a0b
Compare
Contributor
|
I made a similar PR #221. Mine has some more tests, but doesn't have all your functionality. Should I try to pull your changes into my branch, or do you want to try to adapt my code to your branch? |
Contributor
Author
|
@conornash sure of course give it a try 🙂 |
dnouri
added a commit
to conornash/pi-coding-agent
that referenced
this pull request
Aug 30, 2026
Preview complete standalone SVG text returned by read without reopening the tool argument path. Leave text with obvious scripts or external resources undecoded, and keep previews display-only. Co-authored-by: Adam Bobrow <adam@bradwell.ai>
dnouri
added a commit
to conornash/pi-coding-agent
that referenced
this pull request
Aug 30, 2026
Preview complete standalone SVG text returned by read without reopening the tool argument path. Leave text with obvious scripts or external resources undecoded, and keep previews display-only. Co-authored-by: Adam Bobrow <adam@bradwell.ai>
dnouri
added a commit
to conornash/pi-coding-agent
that referenced
this pull request
Aug 30, 2026
Preview complete standalone SVG text returned by read without reopening the tool argument path. Leave text with obvious scripts or external resources undecoded, and keep previews display-only. Co-authored-by: Adam Bobrow <adam@bradwell.ai>
dnouri
added a commit
that referenced
this pull request
Aug 30, 2026
* Keep test dependencies consistent across Emacs processes Keep dependency installs project-local per Emacs major and pass the selected Emacs and package directory to child batch, GUI, and benchmark processes. Preserve the existing in-tree compile behavior. Co-authored-by: Daniel Nouri <daniel.nouri@gmail.com> * Display inline images from tool results (#221) Render completed tool-result image blocks inline in graphical Emacs and as type-and-size placeholders in terminals. Bound each returned source and the number shown per tool, and preserve rendered previews through toggling and cooling. * Preview SVG results returned by read (#211) Preview complete standalone SVG text returned by read without reopening the tool argument path. Leave text with obvious scripts or external resources undecoded, and keep previews display-only. Co-authored-by: Adam Bobrow <adam@bradwell.ai> --------- Co-authored-by: Lugh <lugh@Kaji.local> Co-authored-by: Daniel Nouri <daniel.nouri@gmail.com> Co-authored-by: Conor Nash <conor@nbs.consulting> Co-authored-by: Adam Bobrow <adam@bradwell.ai>
Owner
|
Thanks @bobrowadam. #221 has now merged and consolidated this implementation, including returned SVG previews, while preserving your co-authorship. Closing this PR as superseded by #221. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds inline image rendering for image content blocks and local image files read through tools.
This makes visual results visible directly in the Emacs chat buffer instead of showing only text placeholders.