Skip to content

[main] Update dependencies from dotnet/arcade, dotnet/arcade-services, dotnet/dnceng - #17348

Merged
ViktorHofer merged 4 commits into
mainfrom
darc-main-6bc36683-4e63-43b5-8884-2f3c0d82e2bc
Aug 24, 2026
Merged

ViktorHofer merged 4 commits into
mainfrom
darc-main-6bc36683-4e63-43b5-8884-2f3c0d82e2bc

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade-services

From https://github.com/dotnet/dnceng

From https://github.com/dotnet/arcade

…ild 20260813.1

On relative base path root
Microsoft.DotNet.DarcLib , Microsoft.DotNet.ProductConstructionService.Client From Version 1.1.0-beta.26374.1 -> To Version 1.1.0-beta.26413.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/arcade-services [main] Update dependencies from dotnet/arcade-services, dotnet/dnceng Aug 17, 2026
…814.1

On relative base path root
Microsoft.DncEng.SecretManager From Version 1.1.0-beta.26407.1 -> To Version 1.1.0-beta.26414.1
@github-actions

This comment has been minimized.

…818.5

On relative base path root
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 11.0.0-beta.26414.2 -> To Version 11.0.0-beta.26418.5
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/arcade-services, dotnet/dnceng [main] Update dependencies from dotnet/arcade, dotnet/arcade-services, dotnet/dnceng Aug 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Build Failure Analysis

Summary — The updated Microsoft.DotNet.ProductConstructionService.Client package (bumped from 1.1.0-beta.26374.1 to 1.1.0-beta.26413.1) changed the GetBuildAsync method signature so that the second parameter is now bool? (likely loadCollections) rather than CancellationToken, breaking two call sites in PublishBuildToMaestro.cs.

Root cause: GetBuildAsync API breaking change in ProductConstructionService.Client

The new client version inserted a bool? loadCollections parameter as the second positional argument, pushing CancellationToken to a later position. The two callers in PublishBuildToMaestro.cs still pass cancellationToken as the second positional argument, which the compiler now rejects as CS1503.

Affected files / errors

Proposed fix

Pass cancellationToken as a named argument at both call sites so the compiler resolves it to the correct (now later) parameter position:

-                    producingBuild = await client.Builds.GetBuildAsync(asset.BuildId, cancellationToken);
+                    producingBuild = await client.Builds.GetBuildAsync(asset.BuildId, cancellationToken: cancellationToken);
-            var build = await client.Builds.GetBuildAsync(buildId.Value, cancellationToken);
+            var build = await client.Builds.GetBuildAsync(buildId.Value, cancellationToken: cancellationToken);

Note: If the new API doesn't have a cancellationToken parameter at all, simply remove the argument. Check the new GetBuildAsync overloads in Microsoft.DotNet.ProductConstructionService.Client v1.1.0-beta.26413.1.


All MSBuild errors (2)
Code Project File:Line Message
CS1503 Microsoft.DotNet.Build.Tasks.Feed PublishBuildToMaestro.cs:362 Argument 2: cannot convert from 'System.Threading.CancellationToken' to 'bool?'
CS1503 Microsoft.DotNet.Build.Tasks.Feed PublishBuildToMaestro.cs:380 Argument 2: cannot convert from 'System.Threading.CancellationToken' to 'bool?'

Both build legs (Linux Debug and Windows Release) failed with the same two errors.


🤖 Generated by the Build Failure Analysis workflow using (a href="(dev.azure.com/redacted) · [Azure DevOps build]((dev.azure.com/redacted) · commit 53e16ab

🤖 Automated content by GitHub Copilot. Generated by the Build Failure Analysis workflow.{ai_credits_suffix} · [◷]( · )

@akoeplinger

Copy link
Copy Markdown
Member

@dkurepa ^

@akoeplinger

Copy link
Copy Markdown
Member

thanks. I wonder if this will break once arcade reaches the VMR since the arcade-services PR has been in a broken state for more than a month there: dotnet/dotnet#7675

(I really wish we uncoupled/removed the arcade-services dependency from the VMR)

@ViktorHofer
ViktorHofer merged commit f345b93 into main Aug 24, 2026
14 of 17 checks passed
@ViktorHofer
ViktorHofer deleted the darc-main-6bc36683-4e63-43b5-8884-2f3c0d82e2bc branch August 24, 2026 06:29
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants