Report correct runtime commit for SDK measurements - #5290
Conversation
Preserve the dotnet/dotnet VMR commit separately and resolve the corresponding dotnet/runtime commit from the VMR source manifest. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Run only Android CoreCLR Release on the Pixel configuration for the private sanity build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Remove the temporary single-configuration validation override after queuing the targeted build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
There was a problem hiding this comment.
Pull request overview
Updates SDK measurement metadata to preserve the VMR commit and report the corresponding dotnet/runtime commit.
Changes:
- Resolves the runtime commit from
source-manifest.json. - Records both VMR and runtime commit hashes.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Treat runtime commit resolution as best-effort so transient network or malformed manifest failures do not prevent versions.json from being written. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/scenarios/shared/versionmanager.py:10
URLErroris imported here but never referenced; the resolver catchesExceptioninstead. Please remove this dead import (otherwise F401-based Python linting will fail).
from urllib.error import URLError
|
I wonder if we should do this in AzDO instead of on the device itself. That should let us only have to do it one time, and cut down on the likelihood of some kind of transient failure on the machine causing us to miss the value for a certain test. |
Resolve the dotnet/runtime commit once while generating the AzDO machine setup for mobile jobs, and leave payload preparation responsible for assembly-derived workload metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
|
Good suggestion. I moved the dotnet/dotnet → dotnet/runtime resolution into |
DrewScoggins
left a comment
DrewScoggins
left a comment
There was a problem hiding this comment.
LGTM, with a response to my one comment.
Runtime repository provenance is now supplied by CI setup, so payload extraction only records Android, iOS, and MAUI workload metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f1a9ef3e-205a-409a-9aec-5ca6a2dbe255
Summary
PERFLAB_DATA_dotnet_commit_hashsrc/source-manifest.jsonPERFLAB_DATA_runtime_commit_hashValidation
Private Android CoreCLR Release sanity build succeeded: build 3055756.