Ad-hoc sign iOS scenario payloads - #5294
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the iOS scenario payload build steps to perform ad-hoc code signing during payload creation (so Apple SDK-derived bundle identifiers are established early), while keeping the existing Helix signing pass for real credentials and entitlements.
Changes:
- Add a shared empty entitlements plist and expose it via
shared.const. - Switch iOS scenario builds to
EnableCodeSigning=truewithCodesignKey=-(ad-hoc signing). - For MAUI iOS scenarios, explicitly pass the empty entitlements file to avoid relying on provisioning profiles on hosted agents.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/scenarios/shared/EmptyEntitlements.plist | Adds an explicit empty entitlements plist for ad-hoc signing scenarios. |
| src/scenarios/shared/const.py | Adds EMPTY_ENTITLEMENTS path constant for reuse by scenarios. |
| src/scenarios/netios/pre.py | Enables ad-hoc signing for the netios IPA build. |
| src/scenarios/mauisamplecontentios/pre.py | Enables ad-hoc signing and supplies empty entitlements for MAUI sample-content iOS build. |
| src/scenarios/mauiios/pre.py | Enables ad-hoc signing and supplies empty entitlements for MAUI iOS build. |
| src/scenarios/mauiblazorios/pre.py | Enables ad-hoc signing and supplies empty entitlements for MAUI Blazor iOS build. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LoopedBard3
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Internal pipeline build 3059874 passed all five MAUI iOS configurations: Mono, CoreCLR Release, CoreCLR Debug, NativeAOT, and the .NET 10 baseline.