Cross-build browser WASM performance host tools - #133143
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 6 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
This changes cross-build behavior in the build graph and performance pipeline; it needs end-to-end CI validation to confirm it packages and runs correctly across the intended Linux environments.
Pull request overview
Adds an opt-in MSBuild property to control whether the CoreCLR host cross-components child build is invoked with CrossBuild=true, and enables that opt-in for the browser WASM performance build job to allow cross-building the host toolset in that scenario.
Changes:
- Introduced
CrossBuildHostTools(defaulting tofalse) to gate cross-building of the host cross-components build. - Switched the CoreCLR cross-tools
runtime.projchild invocation fromCrossBuild=falsetoCrossBuild=$(CrossBuildHostTools). - Enabled
/p:CrossBuildHostTools=truefor thebrowser_wasmCoreCLR perf build job.
File summaries
| File | Description |
|---|---|
| eng/Subsets.props | Adds CrossBuildHostTools and uses it to control CrossBuild for the CoreCLR host cross-components child build. |
| eng/pipelines/performance/templates/perf-wasm-build-jobs.yml | Enables CrossBuildHostTools for the browser WASM CoreCLR perf build. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
Member
Author
|
performance pr is dotnet/performance#5297 pipeline failure is https://dev.azure.com/dnceng-public/public/_build/results?buildId=1579905&view=results |
This was referenced Sep 3, 2026
Open
maraf
approved these changes
Sep 3, 2026
Member
Author
|
/ba0g the sos failures are tracked in #133175 |
Member
Author
|
/ba-g the sos failures are tracked in #133175 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CrossBuildHostToolsproperty that defaults tofalseValidation
ProjectToBuildwith the repository SDK and confirmed the default host child remainsCrossBuild=falseCrossBuild=true, withClrWasmJitSubset=trueandCLR_CROSS_COMPONENTS_BUILD=1CrossBuildunsetclr.crossarchtools+clr.tools+packsgraph includes the cross-built WASM JIT and host Crossgen2 packgit diff --checkNative GLIBC dependency inspection was not run locally because the development workspace is macOS without the Linux webassembly container. A
runtime-wasm-perfrun is required to verify the packaged JIT against Ubuntu 22.04 end to end.Note
This pull request description was generated with GitHub Copilot.