Make GDI+ and encoder init thread-safe; add concurrency tests - #14896
Draft
KlausLoeffelmann wants to merge 1 commit into
Draft
Make GDI+ and encoder init thread-safe; add concurrency tests#14896KlausLoeffelmann wants to merge 1 commit into
KlausLoeffelmann wants to merge 1 commit into
Conversation
* Introduce thread-safe initialization in GdiPlusInitialization and ImageCodecInfoHelper using locks and Volatile.Read/Write to prevent race conditions during concurrent first use. * Move encoder creation logic to a new CreateEncoders method. * Add ImageConcurrencyTests.cs to verify thread safety of GDI+ and encoder cache initialization under parallel access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves thread safety and concurrency handling in GDI+ initialization and image encoder caching. It introduces proper locking and volatile access patterns to prevent race conditions when these resources are accessed concurrently, and adds new tests to verify correct concurrent behavior.
Fixes #14884.
Thread safety and concurrency improvements:
GdiPlusInitialization.EnsureInitializedandIsInitialized, ensuring GDI+ is initialized safely under concurrent access. [1] [2]ImageCodecInfoHelper, preventing race conditions when building or accessing the encoder list. [1] [2] [3]Testing enhancements:
ImageConcurrencyTests.csto verify that concurrent first use of GDI+ initialization and encoder cache works correctly without failures or race conditions.Microsoft Reviewers: Open in CodeFlow