serial_panel: allow a far side device to reconnect to the port if the connection is previously closed - #141
Open
joshanne wants to merge 1 commit into
Conversation
… connection is previously closed Receiving a zero-byte payload now triggers socket disconnect instead of failing silently. Prevents dropped connections from leaving the serial passthrough unresponsive.
There was a problem hiding this comment.
Pull request overview
This PR improves robustness of the serial passthrough “uCenter” socket handling by treating a zero-byte recv() (peer disconnect) as a real disconnect, closing the socket/tunnel so the listener can accept a new connection rather than getting stuck in an unresponsive state.
Changes:
- Close and null out the active socket/tunnel when
sock.recv()returns an empty payload, enabling reconnection. - Add a
self.tunnel is Noneguard inprocess_tunnel()to avoid follow-on errors after the socket/tunnel has been closed during the same timer tick.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
patrickelectric
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Receiving a zero-byte payload now triggers socket disconnect instead of failing silently.
Prevents dropped connections from leaving the serial passthrough unresponsive.