refactor(dom): rename @dunky.dev/dom-navigation to @dunky.dev/browser-navigation - #46
Merged
Conversation
…-navigation The util guards the browser's session history — Back, Forward, reload — and never touches the DOM, so the old name pointed at the wrong layer. API unchanged; the directory stays packages/dom/utils/navigation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ivanbanov
added a commit
that referenced
this pull request
Aug 24, 2026
main's #46 renamed @dunky.dev/dom-navigation to @dunky.dev/browser-navigation and #48 hardened the same interceptor this branch extends. Two conflicts, both unions rather than choices: - detachWhenIdle: the listener now outlives armed guards, parked watchers, in-flight self-caused pops, AND undecided releases. Dropping the parked check would end a Forward watch the moment its layer closed. - The unwind loop: main removes the guard by identity (onBack may have released it, and a positional pop would evict the guard beneath). Parking now happens only when that removal actually found the guard — a layer that released itself inside onBack tore itself down rather than closing, so there is nothing to offer a reopen to. New test and SPEC clause for it. The changeset follows the rename. Full suite (240), typecheck, lint, format, and build pass; SPECs reconciled against the merged code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the
@dunky.dev/dom-navigationpackage to@dunky.dev/browser-navigation. The API is unchanged —interceptBackNavigationand its contract are untouched — and the directory stayspackages/dom/utils/navigation.Why
The util guards the browser's session history (Back, Forward, reload) and never touches the DOM, so the
dom-prefix pointed at the wrong layer.browser-navigationnames what it actually owns.Changes
packages/dom/utils/navigation: package name, README, changelog H1 (historical entries left as-is)@dunky.dev/dom-dialog: dependency and import updated, deps re-sorted alphabeticallytsconfig.jsonpath alias andpnpm-lock.yamlregenerated@dunky.dev/browser-navigation, patch for@dunky.dev/dom-dialog@dunky.dev/dom-navigationwill receive no further releases.🤖 Generated with Claude Code