Fix console input cursor not repositioning after output

[SougandhS]

Added repositionCaretAfterOutput() to IOConsoleViewer to move the caret to the next writable input partition whenever output is written.
Before :

After :

Fixes : #2127

[github-actions]

Test Results

    54 files  ±0      54 suites  ±0   59m 35s ⏱️ + 1m 21s
 4 705 tests +2   4 683 ✅ +3   22 💤 ±0  0 ❌  - 1 
12 006 runs  +3  11 853 ✅ +4  153 💤 ±0  0 ❌  - 1 

Results for commit 90552f6. ± Comparison against base commit 7beef1c.

♻️ This comment has been updated with latest results.

[Copilot]

Pull request overview

This PR addresses Eclipse console usability by ensuring the input caret is repositioned to the next writable input partition after program output is written, aligning behavior with expectations described in issue #2127.

Changes:

• Added repositionCaretAfterOutput() to IOConsoleViewer to move the caret to the next writable input partition.
• Invoked caret repositioning after auto-scroll reveals the end of the document on document change events.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[iloveeclipse]

OK, looks good from the code point of view, tested with this snippet:

public class PrintAndRead {
    public static void main(String[] args) {
    	java.util.Scanner scanner = new java.util.Scanner(System.in);
        while (true) {
            System.out.print("Please type something: ");
            String input = scanner.nextLine();
            System.out.println("You typed: " + input);
        }
    }
}

Could you please add a test for this fix?

[SougandhS]

Could you please add a test for this fix?

Added,
The failures looks unrelated - Passing on local

[iloveeclipse]

Hmm. The failing tests are all about "not yet closed/disposed" consoles, interestingly they are all different and failing in different OS. The common thing is that some console is still "alive" and not closed.

the zoom font must be disposed once its console is removed ==> expected: <true> but was: <false>
org.opentest4j.AssertionFailedError: the zoom font must be disposed once its console is removed ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at org.eclipse.debug.tests.console.ConsoleTests.testRemovingConsoleDisposesZoomFont(ConsoleTests.java:472)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

Console close was not signaled. ==> expected: <true> but was: <false>
org.opentest4j.AssertionFailedError: Console close was not signaled. ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
	at org.eclipse.debug.tests.console.IOConsoleTests.closeConsole(IOConsoleTests.java:211)
	at org.eclipse.debug.tests.console.IOConsoleTests.testConsoleClear(IOConsoleTests.java:258)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

[console has been added] 
Expected size: 1 but was: 2 in:
[Console [Test clear], Console [MockProcess]]
java.lang.AssertionError: 
[console has been added] 
Expected size: 1 but was: 2 in:
[Console [Test clear], Console [MockProcess]]
	at org.eclipse.debug.tests.console.ProcessConsoleManagerTests.testProcessConsoleLifecycle(ProcessConsoleManagerTests.java:88)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

[SougandhS]

Build looks good now 👍

[iloveeclipse]

Hmm. The failing tests are all about "not yet closed/disposed" consoles, interestingly they are all different and failing in different OS. The common thing is that some console is still "alive" and not closed.

I've created #2852.

[iloveeclipse]

Thanks!