Remove unused org.eclipse.team.internal.core.streams - #2857
Draft
vogella wants to merge 1 commit into
Draft
Conversation
Every caller of this package lived in org.eclipse.team.cvs.core or org.eclipse.team.cvs.ssh2, and all of them disappeared with 7592b18 "Retire CVS from master". The package was moved into org.eclipse.team.core by 68ca795 precisely so the CVS core bundle and the ssh fragments could share one copy of the stream filters, so serving CVS was its only reason to live here. No non-CVS caller ever existed outside the package's own test. The eight stream classes form a closed cluster: the five orphaned by CVS plus PollingInputStream, which only SizeConstrainedInputStream used, and the two line-delimiter filters, whose only remaining client was StreamTests. That test goes away with them, along with its entry in AllTeamTests, the x-friends export of the package and the five message keys nothing references any more. The package was exported only via x-friends, naming the three deleted CVS bundles plus org.eclipse.team.ui and org.eclipse.team.tests.core, neither of which imports it. Removing it is therefore not an API change. Fixes eclipse-platform#2856
Member
|
Ideally in 4.42, removing just before 4.41 M3 is too risky for downstream. |
Contributor
Test Results 54 files ±0 54 suites ±0 56m 18s ⏱️ - 1m 24s Results for commit 8f5dac9. ± Comparison against base commit 7763306. This pull request removes 2 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every caller of
org.eclipse.team.internal.core.streamslived inorg.eclipse.team.cvs.coreororg.eclipse.team.cvs.ssh2, and all of them disappeared with 7592b18 "Retire CVS from master" in 2022. The package had been moved intoorg.eclipse.team.coreby 68ca795 precisely so the CVS core bundle and the ssh fragments could share one copy of the stream filters, so serving CVS was its only reason to live here, and no non-CVS caller ever existed outside the package's own test.The eight classes form a closed cluster, so the whole package goes: the five orphaned directly by the CVS removal,
PollingInputStreamwhich onlySizeConstrainedInputStreamused, and the two line-delimiter filters whose only remaining client wasStreamTests. That test is removed with them, together with its entry inAllTeamTests, thex-friendsexport and five message keys nothing references any more. This drops about 1,200 lines.Removing the export is not an API change: the package was exported only via
x-friends, naming the three deleted CVS bundles plusorg.eclipse.team.uiandorg.eclipse.team.tests.core, and neither of the latter two imports it.Fixes #2856