Remove unused WeakRefList - #2858
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
Test Results 54 files ±0 54 suites ±0 58m 44s ⏱️ -10s For more details on these failures, see this check. Results for commit a662063. ± Comparison against base commit 1cc9ae4. ♻️ This comment has been updated with latest results. |
WeakRefList holds weak references to injected objects so that the list does not keep them alive. It arrived with bug 295880 and its only client was ContextInjector, which stopped using it in 2b16cac "Bug 304586 - Injected methods only react to changes to method arguments" on 2010-03-03. Nothing has referenced it since. The package is exported with x-friends naming org.eclipse.e4.core.contexts and org.eclipse.e4.ui.workbench. Neither imports the class, so the export needs no change and no API is affected.
vogella
force-pushed
the
remove-unused-weakreflist
branch
from
August 7, 2026 12:05
a8c9d9b to
a662063
Compare
vogella
marked this pull request as ready for review
August 7, 2026 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeakRefListholds weak references to injected objects so the list itself does not keep them alive. It arrived with bug 295880 and its only client wasContextInjector, which stopped using it in 2b16cac "Bug 304586 - Injected methods only react to changes to method arguments" on 2010-03-03. Nothing has referenced it in the roughly sixteen years since, so this drops 80 lines of dead code.The package is exported with
x-friendsnamingorg.eclipse.e4.core.contextsandorg.eclipse.e4.ui.workbench. I checked both, the former here and the latter in eclipse.platform.ui, and neither imports the class, so the export needs no change and no API is affected.