restore current working directory in terminal even if directory selected - #2859
Open
danthe1st wants to merge 1 commit into
Open
restore current working directory in terminal even if directory selected#2859danthe1st wants to merge 1 commit into
danthe1st wants to merge 1 commit into
Conversation
danthe1st
force-pushed
the
terminal-restore-directories
branch
2 times, most recently
from
August 8, 2026 13:40
d8fe8ed to
2320426
Compare
When the terminals in the terminal view were restored with a directory selected, all the terminals to restore were set to use the directory of the selection. With this change, the selection is only used for new terminals and not for ones that are restored.
danthe1st
force-pushed
the
terminal-restore-directories
branch
from
August 8, 2026 13:41
2320426 to
589e01d
Compare
Contributor
Test Results 36 files - 18 36 suites - 18 38m 46s ⏱️ - 20m 8s Results for commit 589e01d. ± Comparison against base commit 1cc9ae4. This pull request skips 1 test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new terminal with a folder selected (by pressing Ctrl+Alt+T) with terminals to be restored (i.e. #2850 is enabled and there are terminals from a previous session), Eclipse currently resets the working directory of the folders to be restored to the selection (and the new terminal is also using that selection).
This PR changes this by only using the selection for new terminals. As the new terminal was previously added at the beginning of the
CTabFolder/list of terminals (because the order of the terminals being opened was wrong), I also made sure that the newly opened terminal is at the very right where it should be.I hope nobody relies on this broken behaviour (otherwise I could add a preference for the first fix but I don't really see why anyone would want that).