ci: do not block Changesets version on snapshot publish - #866
Merged
Conversation
The reusable CI workflow included Publish Snapshot, so the version job waited on pkg.pr.new. Snapshot now lives in its own reusable workflow: PRs still publish after build, and on main snapshot is a sibling of version after lint/build/test.
patroza
marked this pull request as ready for review
August 14, 2026 06:29
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
main, Changesets calls the reusable CI workflow and then runsversionwithneeds: [ci]. Publish Snapshot lived inside that reusable workflow, so version waited on pkg.pr.new even though the two jobs do not depend on each other.Snapshot is now its own reusable workflow:
build(lint/test stay parallel).release.yaml):snapshotandversionbothneeds: [ci], so they start together after lint/build/test.Version still waits for the quality gates. It no longer waits for snapshot success or failure.
Test plan
mainpush (non-version-bump, non-bot), Changesets showssnapshotandversionas siblings afterciversionfrom startingchore: update versions) still skip snapshotNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.