feat(go2.lic): v2.5.0 expose trip status to supervisors; bound the restart loop

[Nisugi]

Summary

go2 v2.5.0: make a trip's progress observable to supervising scripts, and stop the restart loop from running forever.

• Go2.status struct: phase, blocked reason, its cause symbol, the failing command, destination, rooms_left, last_room, last_progress_at, restarts, max_restarts, eta, started_at
• every change is emitted as go2.status on Lich::Common::Events when that primitive exists; Go2.on_status is the fallback on older Lich, and both receive a frozen snapshot
• Go2.last_result keeps the final :arrived / :failed / :aborted status after the script exits
• --max-restarts=<N> (default 30, 0 = unlimited) bounds the restart loop with a clear give-up message naming the last blocker
• ;go2 status prints a one-line summary

Motivation

A script driving go2 had one signal, Script.running?('go2'). Travelling out of [Hinterwilds, Beaten Path - 29882] while wounded, the exit's search failed with "You are in far too much agony to do that", go path failed, and go2 restarted itself roughly fifteen times over several minutes. Throughout, the supervisor saw "trip underway". A wedged go2 was indistinguishable from a walking one, and the loop had no exit other than success: error_count was never compared to a ceiling and most $go2_restart = true sites never touched it.

The blocked reason is captured from the game lines since the last room title, first failure line wins, so the root cause is reported rather than the cascade of "You can't go there" that typeahead sends afterwards.

Depends on

Draft until elanthia-online/lich-5#1619 (the Lich::Common::Events primitive) lands. The script runs fine without it: the Events.emit is behind a defined? guard and rescued, and Go2.on_status works on any Lich. Once 1619 is released, supervisors should prefer

Events.on('go2.status', name: 'mysupervisor') { |_topic, st| @need_heal = true if st.phase == :blocked }

because that subscription is cleaned up automatically when the listening script dies.

And elanthia-online/lich-5#1622 for the cause field: when that Lich's move() records Lich::Common::Move.last_failure, go2 takes the exact failing line and its classified cause (:injured, :encumbered, :position, :map, ...) from there instead of scraping the buffer, and ;go2 status prints it. On an older Lich cause is nil and the buffer scrape still supplies reason. go2 itself calls move through the unchanged top-level name, so the bounded retries in #1622 apply to every go2 step with no change here.

Behavior notes

• A nested go2 started for a bank detour reports under the outer trip's status rather than resetting it.
• status_finish emits only the terminal phase; the reset to :idle is silent since it is not a transition a supervisor can act on.
• error_count and its lag-check / timeto logic are unchanged; the new ceiling counts restart cycles.

Verification

• ruby -c and rubocop --only Lint clean
• helper logic exercised standalone with stubs: reason selection after the last room title, hidden-title fallback, progress cursor, restart ceiling, frozen payloads, mutation attempts by a listener, emit sequence on the real events.rb, and a raising Events.emit being logged rather than propagated
• not yet exercised on a live trip; the Hinterwilds case above is the intended manual test

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9ee99dde-3397-4fd3-9f1b-2616f29ec9e7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}