fix(engines): tolerate unreadable pages when opening a document - #784
Open
calebkish wants to merge 1 commit into
Open
fix(engines): tolerate unreadable pages when opening a document#784calebkish wants to merge 1 commit into
calebkish wants to merge 1 commit into
Conversation
A single page whose dictionary PDFium cannot parse previously failed the
entire openDocumentBuffer call. Fall back to a 0x0 size for that page and
keep going, matching the resilient page-reading behavior of the v3 engine
(PagesReader in @embedpdf/engine-services).
Also normalize EPDF_GetPageRotationByIndex: it returns -1 on error, which
the downstream `rotation & 3` math would otherwise treat as 270 degrees.
Clamp a failed read to 0.
|
@calebkish is attempting to deploy a commit to the CloudPDF Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single page whose dictionary PDFium cannot parse previously failed the entire openDocumentBuffer call. Fall back to a 0x0 size for that page and keep going, matching the resilient page-reading behavior of the v3 engine (PagesReader in @embedpdf/engine-services).
Also normalize EPDF_GetPageRotationByIndex: it returns -1 on error, which the downstream
rotation & 3math would otherwise treat as 270 degrees. Clamp a failed read to 0.